-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-108303: Remove the non-test Lib/test/reperf.py
#114356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apparently test_embed.py runs this code?
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Ok, looks like it was used recently in #110769 by @ambv I propose to:
|
4752216
to
93da596
Compare
I am now using another file instead of So, we can remove the unneeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd rather not backport the removal.
@encukou looks like this PR #113601 influenced the CI. I fixed tests, so now both
Please, take another look :) |
OK. Thanks! |
Looks like this file was not touched for at least 12 years: https://github.com/python/cpython/commits/main/Lib/test/reperf.py
It does not seem useful. If it is, I can instead move it to
Tool/scripts
.Refs #114354